Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Developer Preferences #1986

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Conversation

mklanjsek
Copy link
Contributor

This change adds the Developer preferences, available only in Electron build. More precisely, it adds developers ability to change the logging verbosity and specify the Frontend Url.

Additional info:

  • Also fixed small css issues with Preferences button,
  • Fixed problem where validation was not running on Preferences form load,

Signed-off-by: Milan Klanjsek mklanjsek@pivotal.io

Which issue(s) this PR fixes

Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
Copy link
Contributor

@wwitzel3 wwitzel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I had a couple minor label changes and a question about retry/alert.

web/main.ts Outdated Show resolved Hide resolved
web/main.ts Outdated Show resolved Hide resolved
web/main.ts Outdated Show resolved Hide resolved
web/main.ts Outdated Show resolved Hide resolved
…osity

Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
@mklanjsek mklanjsek merged commit 5111eb9 into vmware-archive:master Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use electron-store for preferences and consolidate storage.
2 participants