Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Add memstat flag #2127

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

GuessWhoSamFoo
Copy link
Contributor

What this PR does / why we need it:
Allows users to benchmark memory usage without needing additional setup

Which issue(s) this PR fixes

Special notes for your reviewer:
Command can be invoked by:
octant --disable-open-browser --memstats stats.txt --meminterval 500ms

then observe via tail -f stats.txt

Signed-off-by: Sam Foo foos@vmware.com

Signed-off-by: Sam Foo <foos@vmware.com>
Copy link
Contributor

@wwitzel3 wwitzel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is useful. In the future lets think about how we can start to expose these knobs easily through our preferences. We have a developer section that can have flags like this.

@GuessWhoSamFoo GuessWhoSamFoo merged commit 17633d8 into vmware-archive:master Mar 10, 2021
@GuessWhoSamFoo GuessWhoSamFoo deleted the memstats branch March 30, 2021 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants