Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Add expandable rows to datagrids #2179

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

GuessWhoSamFoo
Copy link
Contributor

What this PR does / why we need it:

Peek 2021-03-18 16-19

Allows rows in datagrids to have expandable rows which contains another view component.

Which issue(s) this PR fixes

Signed-off-by: Sam Foo foos@vmware.com

@wwitzel3
Copy link
Contributor

Let's add a storybook example under table for this.

@GuessWhoSamFoo
Copy link
Contributor Author

A clarity table listed under a storybook table does not have expandable rows. Octant calls datagraids as tables which can be confusing which is why there isn't a datagrid entry in storybook either. We will have to decide either to rename or explain the table/datagrid semantics in the table storybook entry.

Signed-off-by: Sam Foo <foos@vmware.com>
@wwitzel3
Copy link
Contributor

A clarity table listed under a storybook table does not have expandable rows. Octant calls datagraids as tables which can be confusing which is why there isn't a datagrid entry in storybook either. We will have to decide either to rename or explain the table/datagrid semantics in the table storybook entry.

Not sure I follow? .. There are two stories under Storybook -> Table one uses DatagridComponent and the other TableComponent , we can't add the expandable row to the one using the DatagridComponent?

@GuessWhoSamFoo
Copy link
Contributor Author

Nevermind, confused table and datagrid with incorrect copypasta

Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few small things.

Signed-off-by: Sam Foo <foos@vmware.com>
@GuessWhoSamFoo GuessWhoSamFoo merged commit b0f62a4 into vmware-archive:master Mar 22, 2021
@GuessWhoSamFoo GuessWhoSamFoo deleted the issue-2019 branch March 22, 2021 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add row detail from Clarity
3 participants