Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Styling for Buttons #2306

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Styling for Buttons #2306

merged 1 commit into from
Apr 19, 2021

Conversation

ftovaro
Copy link
Contributor

@ftovaro ftovaro commented Apr 12, 2021 •
edited
Loading

Signed-off-by: ftovaro f.tovar12@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes

Special notes for your reviewer:
Example of styles and sizes:

image

Example of how to use it:

// Buttons with style
btn1 := component.NewButton("ButtonStyleOutline", action.Payload{}, component.WithButtonStyle(component.ButtonStyleOutline))
btn2 := component.NewButton("ButtonStyleSolid", action.Payload{}, component.WithButtonStyle(component.ButtonStyleSolid))
btn3 := component.NewButton("ButtonStyleFlat", action.Payload{}, component.WithButtonStyle(component.ButtonStyleFlat))

// Buttons with size
btn4 := component.NewButton("ButtonSizeLarge", action.Payload{}, component.WithButtonSize(component.ButtonSizeLarge))
btn5 := component.NewButton("ButtonSizeBlock", action.Payload{}, component.WithButtonSize(component.ButtonSizeBlock))

// Buttons with style
btn6 := component.NewButton("ButtonStatusSuccess", action.Payload{}, component.WithButtonStatus(component.ButtonStatusSuccess))
btn7 := component.NewButton("ButtonStatusInfo", action.Payload{}, component.WithButtonStatus(component.ButtonStatusInfo))
btn8 := component.NewButton("ButtonStatusDanger", action.Payload{}, component.WithButtonStatus(component.ButtonStatusDanger))
btn9 := component.NewButton("ButtonStatusDisabled", action.Payload{}, component.WithButtonStatus(component.ButtonStatusDisabled))

Release note:

release-note

@ftovaro ftovaro force-pushed the issue-2184 branch 2 times, most recently from 4731c9c to 9809768 Compare April 12, 2021 21:21
@ftovaro ftovaro changed the title Add styling for Buttons Styling for Buttons Apr 12, 2021
@ftovaro ftovaro force-pushed the issue-2184 branch 3 times, most recently from 563b60c to f662fc5 Compare April 12, 2021 21:36
@ftovaro ftovaro marked this pull request as ready for review April 12, 2021 22:15
@GuessWhoSamFoo
Copy link
Contributor

All the examples listed needs to be in storybook.

@ftovaro ftovaro force-pushed the issue-2184 branch 2 times, most recently from 3a2569c to eedca15 Compare April 13, 2021 16:40
@GuessWhoSamFoo
Copy link
Contributor

Holding per https://kubernetes.slack.com/archives/CM37M9FCG/p1618336449111900

@ftovaro ftovaro changed the title Styling for Buttons Styling for Buttons [WIP] Apr 13, 2021
@ftovaro
Copy link
Contributor Author

ftovaro commented Apr 13, 2021

Currently working on using Clarity core components

@ftovaro ftovaro force-pushed the issue-2184 branch 3 times, most recently from 2f33cd3 to ed980ed Compare April 15, 2021 18:47
@ftovaro ftovaro changed the title Styling for Buttons [WIP] Styling for Buttons Apr 15, 2021
@ftovaro ftovaro force-pushed the issue-2184 branch 8 times, most recently from 3b05028 to b651371 Compare April 15, 2021 19:49
@ftovaro
Add styling for Buttons
6e9c9ea 
Signed-off-by: ftovaro <f.tovar12@gmail.com>
@lenriquez lenriquez merged commit 62c92d5 into vmware-archive:master Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenriquez lenriquez lenriquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow styling configuration for buttons
3 participants
@ftovaro @GuessWhoSamFoo @lenriquez