This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add tooltip to icon component #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuessWhoSamFoo
force-pushed
the
issue-2307
branch
from
eddb855
to
d959d50
Compare
lenriquez
approved these changes
Apr 22, 2021
| @@ -51,6 +53,17 @@ export class IconComponent extends AbstractViewComponent<IconView> { | |||
|
|
|||
| protected update(): void { | |||
| const view = this.v; | |||
| this.tooltip = view.config.tooltip; | |||
There was a problem hiding this comment.
This function is already long it will be nice to have this functionality in another function
Signed-off-by: Sam Foo <foos@vmware.com>
GuessWhoSamFoo
force-pushed
the
issue-2307
branch
from
d959d50
to
7222b51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a tooltip to icons. Only added to icons as it seems to be the few components where adding a tooltip makes sense over a signpost.
Which issue(s) this PR fixes
Signed-off-by: Sam Foo foos@vmware.com