Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Fix Daemonset incorrectly showing status when pod is unavailable #2389

Merged
merged 1 commit into from
May 3, 2021
Merged

Fix Daemonset incorrectly showing status when pod is unavailable #2389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/1565-GuessWhoSamFoo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed Daemonset incorrectly showing status when pod is unavailable
2 changes: 1 addition & 1 deletion internal/objectstatus/daemonset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func daemonSet(_ context.Context, object runtime.Object, _ store.Store) (ObjectS
nodeStatus: component.NodeStatusWarning,
Details: []component.Component{component.NewText("Daemon Set pods are running on nodes that aren't supposed to run Daemon Set pods")},
}, nil
case status.NumberAvailable != status.NumberReady:
case status.DesiredNumberScheduled != status.NumberReady:
return ObjectStatus{
nodeStatus: component.NodeStatusWarning,
Details: []component.Component{component.NewText("Daemon Set pods are not ready")},
Expand Down
2 changes: 1 addition & 1 deletion pkg/view/component/button.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type ButtonStatus string
const (
// ButtonSizeBlock is a full width button
ButtonSizeBlock ButtonSize = "block"
// ButtonSizeLarge is a small button
// ButtonSizeMedium is a clarity small button
ButtonSizeMedium ButtonSize = "md"
)

Expand Down