This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR assists the user in finding the local path to kube config which is used by octant. It is useful is case when the user has uploaded the config manually via loading api and a temporary kube config file is created and stored in the temp directory.
Which issue(s) this PR fixes
Special notes for your reviewer:
Steps for reproduction/acceptance:
Some implementation decisions:
The
octant.generator
interface now returns multiple events which extends a *_manager's capability to perform multiple small computations and stream back multiple results as events. A managers setup is an overkill for implementing small features. This approach helps with testing by keeping the handlerFunc usage the same as before and avoids generator classes doing duplicated work.