This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Fixes errors when generating TypeScript components #2605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, TypeScript component generation leads to TS components that do not compile, meaning that it is not possible to write plugins for the latest version of Octant in TypeScript. This PR fixes two bugs preventing TS component generation:
FormFieldConfig
is imported and redeclared, causing errors)Testing Steps:
node_modules/@project-octant/plugin/helpers.ts
with the latest version (available here)go run ./cmd/ts-component-gen/main.go -dest <directory>
to generate TypeScript components, where<directory>
is the path tonode_modules/@project-octant/plugin/components
inside your local TypeScript pluginWhich issue(s) this PR fixes