Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Fix panic for standalone pod in applications view #2676

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

GuessWhoSamFoo
Copy link
Contributor

What this PR does / why we need it:
See title

Which issue(s) this PR fixes

Special notes for your reviewer:
Number of running containers is irrelevant. The cause of panic is a pod with no owner reference.

Signed-off-by: Sam Foo foos@vmware.com

Signed-off-by: Sam Foo <foos@vmware.com>
Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, didn't know that could happen.

Copy link
Contributor

@lenriquez lenriquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

@GuessWhoSamFoo GuessWhoSamFoo merged commit 1c39b11 into vmware-archive:master Jul 26, 2021
@GuessWhoSamFoo GuessWhoSamFoo deleted the issue-2650 branch July 26, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octant crashes when clicking a partially-runnning Pod from Applications view
3 participants