This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Enable editing of objects #885
Merged
+819
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanl
changed the title
|
Taking a look this morning. |
This change adds a preview of an editor for object YAML Signed-off-by: bryanl <bryanliles@gmail.com>
ensure fake client has received an event before checking invariants Signed-off-by: bryanl <bryanliles@gmail.com>
Signed-off-by: bryanl <bryanliles@gmail.com>
|
Case: edit a pod's container environment variable (which is not allowed). The error message can be cleaner with only the message "Forbidden: pod updates may not change fields other than...". It'd be even better if those lines can be blocked from editing, but this is not possible in monaco right now (microsoft/monaco-editor#953) |
|
We should catch ctrl + s key presses while the editor component is up. I am programmed to save reflexively after each edit |
wwitzel3
approved these changes
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds a preview of an editor for object YAML