cliSettings: You need to change on the sametime userName and Password...

Bug or feature ?
vmware-archive · Feb 5, 2018 · bc346a6 · bc346a6
1 parent 7aac57a
commit bc346a6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/module/PowerNSX.psm1 b/module/PowerNSX.psm1
@@ -13841,10 +13841,14 @@ function Set-NsxEdge {
 
         #cliSettings
         if ( $PsBoundParameters.ContainsKey('userName') ) {
-            if ( invoke-xpathquery -node $_Edge -querymethod SelectSingleNode -Query "child::cliSettings/userName" ) {
-                $_Edge.cliSettings.username = $userName
+            if ( $PsBoundParameters.ContainsKey('password') ) {
+                if ( invoke-xpathquery -node $_Edge -querymethod SelectSingleNode -Query "child::cliSettings/userName" ) {
+                    $_Edge.cliSettings.username = $userName
+                } else {
+                    Add-XmlElement -xmlroot $_Edge.cliSettings -xmlElementName "userName" -xmlElementText $userName
+                }
             } else {
-                Add-XmlElement -xmlroot $_Edge.cliSettings -xmlElementName "userName" -xmlElementText $userName
+                throw "You need to specify a password for change username..."
             }
         }
 

diff --git a/tests/integration/04.Edge.Tests.ps1 b/tests/integration/04.Edge.Tests.ps1
@@ -734,10 +734,12 @@ Describe "Edge" {
             $edge.cliSettings.remoteAccess | should be "true"
         }
 
-        it "Change (SSH) username via Set-NsxEdge" {
-            Get-NsxEdge $name | Set-NsxEdge -userName powernsxviasetnsxedge -confirm:$false
+        it "Change (SSH) username (and Password) via Set-NsxEdge" {
+            #it is mandatory to change username (and Password) on the same time (bug or feature ?)
+            Get-NsxEdge $name | Set-NsxEdge -userName powernsxviasetnsxedge -Password "Vmware1!Vmware1!" -confirm:$false
             $edge = Get-NsxEdge $name
             $edge.cliSettings.userName | should be "powernsxviasetnsxedge"
+            #It is impossible to check if the password is modified...
         }
 
         it "Change Password Expiry via Set-NsxEdge" {
@@ -751,11 +753,6 @@ Describe "Edge" {
             $edge = Get-NsxEdge $name
             $edge.cliSettings.sshLoginBannerText | should be "Secured by Set-NsxEdge"
         }
-
-        it "Change Password via Set-NsxEdge" {
-            Get-NsxEdge $name | Set-NsxEdge -Password "Vmware1!Vmware1!" -confirm:$false
-            #There is no really check if the value is changed...
-        }
     }
 
     Context "Misc" {