This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Add Get/Set/Remove -NsxDns cmdlets with testsuite #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmbradford @pandom @dcoghlan can you look ? it is no yet finish... (need also to look #425 because need for some tests...) |
alagoutte
changed the title
|
@nmbradford it is possible to launch a jenkins test ? (and get feedback/review) |
Get DNS settings of Edge Service Gateway
Set DNS settings (PrimaryDNS, CacheSize, Status, Log...) of Edge Service Gateway Add also ValidateEdgeDNS to valid it is a Get-NsxDns xml attribut
Remove DNS settings of Edge Service Gateway (alreayd use -NoConfirm to be compliant)
… there is not yet dns server configured)
add dedicated test for retrieve (all) DNS Config and remove each retrieve for other test
|
Can you look ? :) |
|
jenkins test this please |
|
Tests Failed |
|
@alagoutte - The tests failed due to the following error |
dcoghlan
reviewed
Jul 8, 2019
|
Can you retry ? |
|
jenkins test this please |
|
Tests Failed |
dcoghlan
reviewed
Jul 9, 2019
Need also use .ToString() when change the size
|
jenkins test this please |
|
Tests Successful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No yet finish (need to add more tests.. and also statistics)