Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Commit

Permalink
Change GuestOSCustomizable to SupportedGuestOS (#53)
Browse files Browse the repository at this point in the history
The GuestOSDescriptor ids fetched from the cluster
configoptions don't indicate whether the osType is customizable by GOSC or not.
It is a cautionary warning for GuestOS compatibility with the esx hosts of the
cluster.

It makes sense to change the name to SupportedGuestOS
since it will be used to mark osTypes that are considered "unsupported"
as false. Also to mark osTypes that currently unsupported from VM Services' perspective
  • Loading branch information
sreyasn authored Jan 13, 2021
1 parent 2e31dfe commit b911523
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions api/v1alpha1/virtualmachineimage_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ type VirtualMachineImageStatus struct {
// Deprecated
PowerState string `json:"powerState,omitempty"`

// GuestOSCustomizable indicates whether the VirtualMachineImage's osType is supported for
// customisation on the cluster
GuestOSCustomizable *bool `json:"guestOsCustomizable,omitempty"`
// SupportedGuestOS indicates whether the VirtualMachineImage's osType is supported
// by the hosts in the cluster and VM Service
SupportedGuestOS *bool `json:"supportedGuestOS,omitempty"`
}

// +genclient
Expand All @@ -87,7 +87,7 @@ type VirtualMachineImageStatus struct {
// +kubebuilder:printcolumn:name="Version",type="string",JSONPath=".spec.productInfo.version"
// +kubebuilder:printcolumn:name="OsType",type="string",JSONPath=".spec.osInfo.type"
// +kubebuilder:printcolumn:name="Format",type="string",JSONPath=".spec.type"
// +kubebuilder:printcolumn:name="GuestOSCustomizable",type="boolean",priority=1,JSONPath=".status.guestOsCustomizable"
// +kubebuilder:printcolumn:name="SupportedGuestOS",type="boolean",priority=1,JSONPath=".status.supportedGuestOS"

// VirtualMachineImage is the Schema for the virtualmachineimages API
// A VirtualMachineImage represents a VirtualMachine image (e.g. VM template) that can be used as the base image
Expand Down
4 changes: 2 additions & 2 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b911523

Please sign in to comment.