Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Fixing clean-esx util to accommodate log config changes for vDVS driver #1600

Conversation

shuklanirdesh82
Copy link
Contributor

fixes #1160

Correcting clen-esx routine .. there was a bug which was not cleaning up correctly hence there was a workaround added into deploy-esx which was wrong.

Testing done: yes (locally)

from dev machine

make clean-all build-all deploy-esx test-esx
:::::::::::::::::::
:::::::::::::::::::
:::::::::::::::::::
make clean-esx

on ESX

make clean-all build-all deploy-esx test-esx result:

[root@promc-2n-dhcp105-97:~] ls /tmp/
docker-volume-vsphere   nfsgssd_krb5cc          probe.session           vmdk_ops_unittest27325
[root@promc-2n-dhcp105-97:~] ls /etc/vmware/vmdkops/
auth-db                               auth-db.bak_Tue_Jun_27_14:41:30_2017  log_config.json
auth-db.bak_Sat_Jun_24_00:20:59_2017  auth-db.bak_Tue_Jun_27_14:41:58_2017

make clean-esx result:

[root@promc-2n-dhcp105-97:~] ls /etc/vmware/vmdkops/
auth-db                               auth-db.bak_Sat_Jun_24_00:20:59_2017  auth-db.bak_Tue_Jun_27_14:41:30_2017  auth-db.bak_Tue_Jun_27_14:41:58_2017
[root@promc-2n-dhcp105-97:~] ls /tmp/
nfsgssd_krb5cc  probe.session

Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuklanirdesh82 shuklanirdesh82 merged commit 4d1ce0a into vmware-archive:master Jul 18, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the deployToolCleanupIssue1160.shuklanirdesh82 branch July 18, 2017 21:10
@shuklanirdesh82 shuklanirdesh82 restored the deployToolCleanupIssue1160.shuklanirdesh82 branch July 18, 2017 21:10
@shuklanirdesh82 shuklanirdesh82 deleted the deployToolCleanupIssue1160.shuklanirdesh82 branch July 18, 2017 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log config changes for vDVS driver are not applied on CI
4 participants