This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Support test and set of KV via vm listener #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1621 |
msterin
approved these changes
Jul 24, 2017
esx_service/vmdk_ops.py
Outdated
| @@ -1426,7 +1426,7 @@ def disk_detach_int(vmdk_path, vm, device): | |||
| logging.warning("%s\n%s", msg, "".join(traceback.format_tb(ex_traceback))) | |||
| return err(msg) | |||
|
|
|||
| setStatusDetached(vmdk_path) | |||
| setStatusDetached(vmdk_path, key=None, value=None) | |||
| logging.info("Disk detached %s", vmdk_path) | |||
There was a problem hiding this comment.
There is no need to pass key and value here as None foe them is already default.
There was a problem hiding this comment.
Sorry, just cut-paste, fixed.
This was referenced Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the disk_detach_int code path to include optional key, value params. The KV will be written with the given dict only if the current KV data matches the given key, value pair.
Ensuring a test-and-set of the KV in specific scenarios - right now just the VM listener.