This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Enables ssh via Go for Windows OpenSSH Server #1640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables ssh via Go for the Windows OpenSSH Server.
venilnoronha
requested review from
msterin,
govint,
shuklanirdesh82 and
shaominchen
msterin
approved these changes
Jul 26, 2017
|
|
||
| // +build !runoncewin | ||
|
|
||
| package ssh |
There was a problem hiding this comment.
let's not introduce "_" with this PR ... tests/* we have tried to avoid introducing that unless it is necessary.
|
|
||
| // Exposes util to invoke remote commands on windows hosts via ssh. | ||
|
|
||
| // +build runoncewin |
There was a problem hiding this comment.
If I understand correctly, you are controlling to pick up during windows run. I would suggest to use different name avoid using "test" related tags here.
|
@shuklanirdesh82 I've addressed your comments in fbe4a2c under #1643. I've re-created this PR from my private repo, so closing this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
sshviaGofor the WindowsOpenSSHserver. This will aid the development of e2e tests for the Windows plugin.