Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Validate if volume name contains illegal characters #1692

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Validate if volume name contains illegal characters #1692

merged 1 commit into from
Aug 4, 2017

Conversation

shaominchen
Copy link
Contributor

@shaominchen shaominchen commented Aug 3, 2017 •
edited
Loading

Fixes issue #1691:

  1. Validate if volume name contains illegal characters
  2. Update e2e tests to include these negative cases

Testing Done:

  1. Manually verified volume creation with illegal character fail as expected
  2. Passed e2e tests locally

msterin
msterin approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@msterin msterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thanks for taking care of this bug.

shuklanirdesh82
shuklanirdesh82 approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding inline comments.

@shuklanirdesh82 shuklanirdesh82 merged commit c4d2cb3 into vmware-archive:master Aug 4, 2017
@shaominchen shaominchen deleted the issue_1691 branch August 4, 2017 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuklanirdesh82 shuklanirdesh82 shuklanirdesh82 approved these changes

@msterin msterin msterin approved these changes

@lipingxue lipingxue Awaiting requested review from lipingxue

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaominchen @msterin @shuklanirdesh82 @vmwclabot