Update the smb image to our own simpler version #2053
Conversation
| @@ -220,31 +222,12 @@ func (d *DockerOps) StartSMBServer(volName string) (int, string, bool) { | |||
| // The Docker image to run in this service | |||
There was a problem hiding this comment.
Why with this change, there is no need to pass "containerArgs"?
There was a problem hiding this comment.
No we don't need to create the shares or users since we have pre-defined shares inside the image already.
There was a problem hiding this comment.
Then when user need to create a share owned by specific user and with specific access permission, how can we set that? I don't think we can set in image in this case.
There was a problem hiding this comment.
That's right :)
This is a feature we don't support for now (and didn't support before the change too).
We can add it later.
There was a problem hiding this comment.
My only concern here is in the original image, they are configurable in the code. But with this change, it seems hard coded in the image. Is there any way that make it configurable other than hard coded?
There was a problem hiding this comment.
Yes we will need to update the vfilesmb image to include customize functions for creating new users. We can add this when we support the user defined username functionality.
Update the samba image to our own simpler version.