Skip to content

Commit

Permalink
fix(a11y): update role to radiogroup for radio group control (#1378)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
The a11y role for the radiogroup control was set as `group`
<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1196

## What is the new behavior?
Based on discussions with the accessibility team, updated the role to
the more specific `radiogroup` role.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
  • Loading branch information
andyfeds and Andrea Fernandes authored May 2, 2024
1 parent 8f49a6d commit 7342ad2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion projects/angular/src/forms/radio/radio-container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class ClrRadioContainer extends ClrAbstractContainer implements AfterCont
}

private setAriaRoles() {
this.role = this.radios.length ? 'group' : null;
this.role = this.radios.length ? 'radiogroup' : null;
}

private setAriaLabelledBy() {
Expand Down

0 comments on commit 7342ad2

Please sign in to comment.