Skip to content

Commit

Permalink
fix(dropdown): add negative offset to item focus outline (#1454)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

Focus outline is hard to be seen in tab overflow due to being cut

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: N/A

## What is the new behavior?

Outline have offset and it's clearly visible

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
  • Loading branch information
dtsanevmw authored Jun 19, 2024
1 parent fabe66c commit a6d0ba6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions projects/angular/src/popover/dropdown/_dropdown.clarity.scss
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@
}
}
}
&:focus {
outline-offset: calc(-1 * tokens.$cds-global-space-2);
}
}

.btn,
Expand Down

0 comments on commit a6d0ba6

Please sign in to comment.