Skip to content

Commit

Permalink
feat(datagrid): automatically associate page size label
Browse files Browse the repository at this point in the history
The content projected into `clr-dg-page-size` will automatically be
wrapped in a `label` element associated with the page size `select`
element.

BREAKING CHANGE: Any page size `label` workarounds should be removed.
  • Loading branch information
kevinbuhmann committed Jan 5, 2023
1 parent b96eda6 commit e50a118
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion projects/angular/src/data/datagrid/datagrid-page-size.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { Page } from './providers/page';
@Component({
selector: 'clr-dg-page-size',
template: `
<ng-content></ng-content>
<label [for]="pageSizeOptionsId"><ng-content></ng-content></label>
<div class="clr-select-wrapper">
<select [id]="pageSizeOptionsId" [class.clr-page-size-select]="true" [(ngModel)]="page.size">
<option *ngFor="let option of pageSizeOptions" [ngValue]="option">{{ option }}</option>
Expand Down

1 comment on commit e50a118

@kevinbuhmann
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improved fix for VPAT-690.

Please sign in to comment.