Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal, wizard): add full-screen size option #1352

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

kevinbuhmann
Copy link
Member

This is a backport of 1d126fa (#1337) to 16.x.

A full-screen modal or wizard will take up all available screen space except for some padding on all four sides.

Other changes:

  • adjust static css-only modal story styles to accommodate full-screen modals
  • add a story option for long content inside the modal to test scrolling within the modal

CDE-1789

@kevinbuhmann kevinbuhmann requested a review from a team April 9, 2024 20:29
@kevinbuhmann kevinbuhmann self-assigned this Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

This is a backport of 1d126fa (#1337) to 16.x.

A full-screen modal or wizard will take up all available screen space except for some padding on all four sides.

Other changes:
- adjust static css-only modal story styles to accommodate full-screen modals
- add a story option for long content inside the modal to test scrolling within the modal

CDE-1789
@kevinbuhmann kevinbuhmann force-pushed the kevin/full-screen-modal-wizard-16.x branch from 37c8a81 to 328ede0 Compare April 9, 2024 20:30
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This PR introduces visual changes: d785d2c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout kevin/full-screen-modal-wizard-16.x
git fetch https://github.com/vmware-clarity/ng-clarity.git d785d2c7d86e2ee1a8ac7eca6d6b0ba230c08aa5
git cherry-pick d785d2c7d86e2ee1a8ac7eca6d6b0ba230c08aa5
git push

@kevinbuhmann kevinbuhmann merged commit 43b4510 into 16.x Apr 10, 2024
7 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/full-screen-modal-wizard-16.x branch April 10, 2024 09:13
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants