feat(modal, wizard): add full-screen size option
#1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
This comment was marked as outdated.
This comment was marked as outdated.
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
from
95c28f2
to
4b1c5ce
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
2 times, most recently
from
68f3222
to
e87385a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
2 times, most recently
from
1d2ab3b
to
584b8a0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
3 times, most recently
from
c45e256
to
00ba02d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
from
00ba02d
to
9d4b876
Compare
kevinbuhmann
changed the title
full-screen size optionfull-screen size option
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
from
9d4b876
to
4b19c42
Compare
This comment was marked as outdated.
This comment was marked as outdated.
A full-screen modal or wizard will take up all available screen space except for some padding on all four sides. Other changes: - adjust static css-only modal story styles to accommodate full-screen modals - add an option for long content inside the modal to test scrolling within the modal CDE-1789
kevinbuhmann
force-pushed
the
kevin/full-screen-modal-wizard
branch
from
4b19c42
to
dc6231b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Jinnie
approved these changes
Mar 27, 2024
Thanks! I hope it doesn't cause to much of a conflict with your sidebar work. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1337-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1d126fa7040a392232a941eef11acfd9cf706736
# Push it to GitHub
git push --set-upstream origin backport-1337-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.xThen, create a pull request where the |
kevinbuhmann
added a commit
that referenced
this pull request
Apr 9, 2024
This is a backport of 1d126fa (#1337) to 16.x. A full-screen modal or wizard will take up all available screen space except for some padding on all four sides. Other changes: - adjust static css-only modal story styles to accommodate full-screen modals - add a story option for long content inside the modal to test scrolling within the modal CDE-1789
kevinbuhmann
added a commit
that referenced
this pull request
Apr 9, 2024
This is a backport of 1d126fa (#1337) to 16.x. A full-screen modal or wizard will take up all available screen space except for some padding on all four sides. Other changes: - adjust static css-only modal story styles to accommodate full-screen modals - add a story option for long content inside the modal to test scrolling within the modal CDE-1789
kevinbuhmann
added a commit
that referenced
this pull request
Apr 10, 2024
This is a backport of 1d126fa (#1337) to 16.x. A full-screen modal or wizard will take up all available screen space except for some padding on all four sides. Other changes: - adjust static css-only modal story styles to accommodate full-screen modals - add a story option for long content inside the modal to test scrolling within the modal CDE-1789
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A full-screen modal or wizard will take up all available screen space except for some padding on all four sides.
Other changes:
CDE-1789
PR Checklist
PR Type
Feature
What is the current behavior?
No full-screen modal or wizard size option.
Issue Number: CDE-1789
What is the new behavior?
Modals and wizards have a
full-screensize option.Does this PR introduce a breaking change?
No.