-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): align detail caret to top and remove unnecessary checkbox styles #1357
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: d2a9540
|
2c62f6b
to
36c883a
Compare
This PR introduces visual changes: 0e48654
|
36c883a
to
61fdf17
Compare
This PR introduces visual changes: 024ef80
|
61fdf17
to
bba1f6e
Compare
This PR introduces visual changes: 55cfb9e
|
735e004
to
4e6b069
Compare
4e6b069
to
bbf886a
Compare
This PR introduces visual changes: 02086d9
|
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? With #1357 we removed some unnecessary select column styles and added a padding which created a regression on the compact version. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-1897 ## What is the new behavior? Adding proper styles to compact datagrid and add stories. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: GitHub <noreply@github.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Detail caret is aligned to center
Issue Number: CDE-1897
What is the new behavior?
Detail caret is aligned to top
Does this PR introduce a breaking change?
Other information