Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): align compact select column and add stories #1364

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

dtsanevmw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

With #1357 we removed some unnecessary select column styles and added a padding which created a regression on the compact version.

Issue Number: CDE-1897

What is the new behavior?

Adding proper styles to compact datagrid and add stories.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Apr 16, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: cafb00d
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-1897
git fetch https://github.com/vmware-clarity/ng-clarity.git cafb00d2bf32a7388a93c5dc3e308226aef18bf5
git cherry-pick cafb00d2bf32a7388a93c5dc3e308226aef18bf5
git push

Copy link
Contributor

This PR introduces visual changes: f2b53f1
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-1897
git fetch https://github.com/vmware-clarity/ng-clarity.git f2b53f1056e0cb2e19542f96f167f08a5bf56d30
git cherry-pick f2b53f1056e0cb2e19542f96f167f08a5bf56d30
git push

@dtsanevmw dtsanevmw marked this pull request as ready for review April 17, 2024 07:26
@dtsanevmw dtsanevmw requested a review from a team April 17, 2024 07:26
Copy link
Contributor

This PR introduces visual changes: fa3dffc
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-1897
git fetch https://github.com/vmware-clarity/ng-clarity.git fa3dffc1e09067536acb13978838dc2b8d3f22d3
git cherry-pick fa3dffc1e09067536acb13978838dc2b8d3f22d3
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

This PR introduces visual changes: 0b3132f
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-1897
git fetch https://github.com/vmware-clarity/ng-clarity.git 0b3132f364441320a340c7e9372e200eca325075
git cherry-pick 0b3132f364441320a340c7e9372e200eca325075
git push

@dtsanevmw dtsanevmw merged commit e00a2cc into main Apr 18, 2024
7 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/cde-1897 branch April 18, 2024 08:37
Copy link
Contributor

github-actions bot commented May 3, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants