Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Datagrid Manage columns #1418

Closed
kumart-netapp opened this issue Jun 3, 2024 · 4 comments
Closed

Regression in Datagrid Manage columns #1418

kumart-netapp opened this issue Jun 3, 2024 · 4 comments
Assignees

Comments

@kumart-netapp
Copy link

This is a bug report for the @clr Angular or UI versions of the design system.
For the web-component implementation of Clarity (@cds), visit vmware-clarity/core.

If you are a VMware employee or a contractor in VMware, please use our support space in Google Chat to raise Clarity issues.

Describe the bug

After upgrading the clarity to v16.5.0, we are seeing the default hidden columns headers are showing and misplacing the rows data and creating confusion.

How to reproduce

Issue can be seen from official Clarity component docs demo: https://v16.clarity.design/documentation/datagrid/code/hide-show

Below are the exact steps(gif):

clarity_dg_hiddencolumnBug

Expected behavior

Should not show the hidden header by default.

Versions

Clarity version:

  • [ x] v16.5.0

Framework version:
Angular 16.2.12

Device:

  • Type: [e.g. MacBook]
  • OS: Windows 11
  • Browser Chrome
  • Version 125

Additional notes

Add any other notes about the problem here.

@dtsanevmw dtsanevmw self-assigned this Jun 3, 2024
dtsanevmw added a commit that referenced this issue Jun 5, 2024
Backport 02b2e61 from #1419. <br> ## PR
Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

&lt;!-- Please check the one that applies to this PR using
&quot;x&quot;. --&gt;

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

Not hiding the column header on initally set as hidden columns.

&lt;!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. --&gt;

Issue Number: #1418 

## What is the new behavior?

Hiding the initially set columns.

## Does this PR introduce a breaking change?

- [ ] Yes
- [X] No

&lt;!-- If this PR contains a breaking change, please describe the
impact and migration path for existing applications below. --&gt;

## Other information

Co-authored-by: Daniel Tsanev <127101685+dtsanevmw@users.noreply.github.com>
@kumart-netapp
Copy link
Author

When can we expect the fix for 16.x release?

@4nt1m0n
Copy link

4nt1m0n commented Jun 21, 2024

When can we expect the 17.x release?

@dtsanevmw
Copy link
Contributor

We just released today!

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants