-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clr-tree throws ExpressionChangedAfterItHasBeenCheckedError #1562
Comments
As a workaround for this issue you can invoke the
|
13 tasks
valentin-mladenov
added a commit
that referenced
this issue
Sep 30, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? `clr-tree` throws ExpressionChangedAfterItHasBeenCheckedError when setting `aria-multiselectable`. Issue Number: #1562, CDE-2301 ## What is the new behavior? Aria multiselectable attribute is added when needed. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information
github-actions bot
pushed a commit
that referenced
this issue
Sep 30, 2024
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? `clr-tree` throws ExpressionChangedAfterItHasBeenCheckedError when setting `aria-multiselectable`. Issue Number: #1562, CDE-2301 ## What is the new behavior? Aria multiselectable attribute is added when needed. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information (cherry picked from commit 71b0056)
13 tasks
The fix will be available with the next v17 release. |
valentin-mladenov
added a commit
that referenced
this issue
Sep 30, 2024
…ort to 16.x) (#1572) Backport 71b0056 from #1563. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? `clr-tree` throws ExpressionChangedAfterItHasBeenCheckedError when setting `aria-multiselectable`. Issue Number: #1562, CDE-2301 ## What is the new behavior? Aria multiselectable attribute is added when needed. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information Co-authored-by: Valentin Mladenov <valentin.mladenov@broadcom.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a bug report for the
@clr
Angular or UI versions of the design system.For the web-component implementation of Clarity (
@cds
), visit vmware-clarity/core.Describe the bug
The
clr-tree
component throws aExpressionChangedAfterItHasBeenCheckedError
since it binds thearia-multiselectable
attribute toisMultiSelectable
.How to reproduce
The bug can be easily reproduced by running your recursive tree example in stackblitz:
https://clarity.design/documentation/tree-view/code#recursive-tree
Expected behavior
An exception should not be thrown when running the recursive tree example code.
Versions
Clarity version:
Framework version:
Angular 16 & 17
Device:
Additional notes
Add any other notes about the problem here.
The text was updated successfully, but these errors were encountered: