Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard): update left border color of currently active step #1574

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Left border color for currently active page is same as future pages --cds-alias-status-neutral-tint.

Issue Number: CDE-2307

What is the new behavior?

Left border color for currently active page is different than other pages --cds-alias-object-interaction-background-highlight.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov self-assigned this Oct 1, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review October 1, 2024 10:29
@valentin-mladenov valentin-mladenov requested a review from a team October 1, 2024 10:30
Copy link
Contributor

github-actions bot commented Oct 1, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Oct 1, 2024

This PR introduces visual changes: 5fb62f5
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout update-wizard-pipe-color_cde-2307
git fetch https://github.com/vmware-clarity/ng-clarity.git 5fb62f5467a1b749f7d495df11962bb8f5286942
git cherry-pick 5fb62f5467a1b749f7d495df11962bb8f5286942
git push

Copy link
Contributor

@LynxDelli LynxDelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valentin-mladenov valentin-mladenov merged commit 44a8918 into main Oct 1, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the update-wizard-pipe-color_cde-2307 branch October 1, 2024 12:54
Copy link
Contributor

github-actions bot commented Oct 2, 2024

🎉 This PR is included in version 17.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants