Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard): update left border color of currently active step #1574

Merged
merged 2 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/angular/src/wizard/STYLES.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
| --clr-wizard-stepnav-border-size | Wizard navigation border size |
| --clr-wizard-stepnav-item-border-color | Wizard navigation border color |
| --clr-wizard-stepnav-item-border-color--active | Wizard navigation item complete border color (misnamed) |
| --clr-wizard-stepnav-selected-border-color | Wizard navigation border color of current not completed step |
| --clr-wizard-stepnav-active-bgcolor | _Deprecated in v18_ Wizard navigation background color for the currently selected element |
| --clr-wizard-stepnav-selected-bgcolor | Wizard navigation background color for the currently selected element |
| --clr-wizard-stepnav-selected-hover-bgcolor | Wizard navigation background color for the currently hovered selected element |
Expand Down
1 change: 1 addition & 0 deletions projects/angular/src/wizard/_properties.wizard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
--clr-wizard-stepnav-border-size: #{tokens.$cds-global-space-3};
// @TODO v18 rename to --clr-wizard-stepnav-item-complete-border-color
--clr-wizard-stepnav-item-border-color--active: #{tokens.$cds-alias-status-success};
--clr-wizard-stepnav-selected-border-color: #{tokens.$cds-alias-object-interaction-background-highlight};
// @TODO v18 remove in favor of --clr-wizard-stepnav-selected-bgcolor
--clr-wizard-stepnav-active-bgcolor: #{tokens.$cds-alias-object-interaction-background-selected};
--clr-wizard-stepnav-selected-bgcolor: var(--clr-wizard-stepnav-active-bgcolor);
Expand Down
1 change: 1 addition & 0 deletions projects/angular/src/wizard/_variables.wizard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ $clr-wizard-stepnav-border-color: var(--clr-wizard-stepnav-border-color) !defaul
$clr-wizard-stepnav-border-size: var(--clr-wizard-stepnav-border-size) !default;
$clr-wizard-stepnav-item-border-color: var(--clr-wizard-stepnav-item-border-color) !default;
$clr-wizard-stepnav-item-border-color--active: var(--clr-wizard-stepnav-item-border-color--active) !default;
$clr-wizard-stepnav-selected-border-color: var(--clr-wizard-stepnav-selected-border-color) !default;
$clr-wizard-stepnav-active-bgcolor: var(--clr-wizard-stepnav-active-bgcolor) !default;
$clr-wizard-stepnav-selected-bgcolor: var(--clr-wizard-stepnav-selected-bgcolor) !default;
$clr-wizard-stepnav-selected-hover-bgcolor: var(--clr-wizard-stepnav-selected-hover-bgcolor) !default;
Expand Down
1 change: 1 addition & 0 deletions projects/angular/src/wizard/_wizard.clarity.scss
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@
&.active {
color: wizard-variables.$clr-wizard-stepnav-text--active;
background-color: wizard-variables.$clr-wizard-stepnav-selected-bgcolor;
border-left-color: wizard-variables.$clr-wizard-stepnav-selected-border-color;

&:hover {
background-color: wizard-variables.$clr-wizard-stepnav-selected-hover-bgcolor;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/chromium/wizard/wizard--wizard-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/chromium/wizard/wizard--wizard-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/wizard/wizard--wizard-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/wizard/wizard--wizard-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading