fix(datagrid): remove setTimeout and check visibility for calculations

[dtsanevmw]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

There was added setTimeout #1494 in the renderer to fix an issue with datagrid being in accordion but that creates different issue - #1569. The main root cause of the wrong widths inside the accordion come from that the content of accordion is using separate component with ng-content and that is projected inside accordion-panel wrapped in *ngIf which seems okey but Angular life cycles go trough that content component before the condition on the ngIf is met so the calculations are being done wrongly on invisible datagrid. In header-renderer scrollWidth is 0 due to that the component is not actually visible after it's visible "shouldStabilizeColumns" is already false and no more re-calculations are being done.

Issue Number: #1569

What is the new behavior?

Do the calculations when the datagrid is actually visible in the DOM.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[kevinbuhmann]

LGTM, I didn't test anything though.

[kevinbuhmann]

See comment.

[github-actions]

👋 @dtsanevmw,

• 🙏 The Clarity team thanks you for opening a pull request
• 🎉 The build for this PR has succeeded
• 🔍 The PR is now ready for review
• 🍿 In the meantime, view a preview of this PR
• 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

[valentin-mladenov]

Check my comments

[github-actions]

This PR introduces visual changes: 1c6e608
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/datagrid_visibility_issue
git fetch https://github.com/vmware-clarity/ng-clarity.git 1c6e60883e8675812385de58bc1c28eefc4713af
git cherry-pick 1c6e60883e8675812385de58bc1c28eefc4713af
git push

[github-actions]

🎉 This PR is included in version 17.3.1 🎉

The release is available on:

• GitHub release
• v17.3.1

Your semantic-release bot 📦🚀

[github-actions]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.