feat(file-input): add file input component #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbuhmann
changed the title
Thank you, 🤖 Clarity Release Bot |
This commit deprecates the previous `.clr-file-wrapper` styles due to design changes. The component uses separate `.clr-file-input-wrapper` styles. There is a visual bug with the helper and error/success text in the compact layout. This is a existing bug that exists will all of the form controls. We will address this separately. CDE-1668
kevinbuhmann
force-pushed
the
kevin/file-input
branch
from
02a472f
to
14bd45a
Compare
valentin-mladenov
requested changes
Apr 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This PR introduces visual changes: 4b3e87b |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1373-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7a61bf4302d1c77cb00448570cfa0d066687974d
# Push it to GitHub
git push --set-upstream origin backport-1373-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.xThen, create a pull request where the |
kevinbuhmann
added a commit
that referenced
this pull request
May 30, 2024
This is a port of 7a61bf4 (#1373) to 16.x. This commit introduces the file input/picker component. The previous undocumented `.clr-file-wrapper` styles are now deprecated due to design changes. The component uses separate `.clr-file-input-wrapper` styles, and these styles supersede the deprecated styles for CSS-only implementations. CDE-1668
kevinbuhmann
added a commit
that referenced
this pull request
May 30, 2024
This is a port of 7a61bf4 (#1373) to 16.x. This commit introduces the file input/picker component. The previous undocumented `.clr-file-wrapper` styles are now deprecated due to design changes. The component uses separate `.clr-file-input-wrapper` styles, and these styles supersede the deprecated styles for CSS-only implementations. CDE-1668
|
🎉 This PR is included in version 17.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Please update the component documentation(https://clarity.design) as well. |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Feature
What is the new feature?
Introduce file input component. Only the basic mode is implemented. The advanced mode will be added later.
Issue Number: CDE-1668
Does this PR introduce a breaking change?
No.
Other information
.clr-file-wrapperstyles due to design changes. The component uses separate.clr-file-input-wrapperstyles, and these styles supersede the deprecated styles for CSS-only implementations.