Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update interaction colors and add temporary tokens #1412

Merged
merged 9 commits into from
May 30, 2024

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented May 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

No difference on hover/active states on selected elements

Issue Number: CDE-2047, CDE-2038

What is the new behavior?

Different hover/active states on selected elements

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented May 30, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/update_interaction_colors branch from f9461cc to d982442 Compare May 30, 2024 08:58
Copy link
Contributor

This PR introduces visual changes: 7f68339
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/update_interaction_colors
git fetch https://github.com/vmware-clarity/ng-clarity.git 7f6833908ca3bc39cbb99be3363086ccc1cab5c4
git cherry-pick 7f6833908ca3bc39cbb99be3363086ccc1cab5c4
git push

@dtsanevmw dtsanevmw marked this pull request as ready for review May 30, 2024 09:19
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment.

projects/ui/src/temp-overrides.scss Outdated Show resolved Hide resolved
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/update_interaction_colors branch 2 times, most recently from aced981 to 6df0ada Compare May 30, 2024 11:51
@valentin-mladenov valentin-mladenov self-requested a review May 30, 2024 11:57
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/update_interaction_colors branch 2 times, most recently from 63aeb76 to 43d4686 Compare May 30, 2024 12:18
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/update_interaction_colors branch from 43d4686 to 84a3fad Compare May 30, 2024 12:25
Copy link
Contributor

This PR introduces visual changes: 80a3dc1
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/update_interaction_colors
git fetch https://github.com/vmware-clarity/ng-clarity.git 80a3dc10512279b3d3d94860d530658850091df5
git cherry-pick 80a3dc10512279b3d3d94860d530658850091df5
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅

@dtsanevmw dtsanevmw merged commit c1e6704 into main May 30, 2024
7 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/update_interaction_colors branch May 30, 2024 13:10
Copy link
Contributor

🎉 This PR is included in version 17.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants