-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): previously hidden columns visible after detail close #1428
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
150dbd3
to
beba891
Compare
beba891
to
e2320b3
Compare
e2320b3
to
8316294
Compare
8316294
to
5cd1ccb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment check if it make sense.
…1428) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Changing the page with detail open closes the detail and the columns which were hidden are still hidden. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2067 ## What is the new behavior? Columns will be visible again once the detail is closed. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information (cherry picked from commit 93915a1)
…1428) Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: Changing the page with detail open closes the detail and the columns which were hidden are still hidden. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2067 Columns will be visible again once the detail is closed. - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> (cherry picked from commit 93915a1)
…backport to 16.x) (#1443) Backport 93915a1 from #1428. <br> ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Changing the page with detail open closes the detail and the columns which were hidden are still hidden. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: CDE-2067 ## What is the new behavior? Columns will be visible again once the detail is closed. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Co-authored-by: Daniel Tsanev <127101685+dtsanevmw@users.noreply.github.com>
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Changing the page with detail open closes the detail and the columns which were hidden are still hidden.
Issue Number: CDE-2067
What is the new behavior?
Columns will be visible again once the detail is closed.
Does this PR introduce a breaking change?
Other information