Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stack-view): space not working in textarea (backport to 16.x) #1482

Merged
merged 2 commits into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. fix(stack-view): space not working in textarea (#1480)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [x] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    Using `Space` button in textarea in stack view triggers expand/collapse
    and is not registred in it.
    
    Issue Number: CDE-1939
    
    ## What is the new behavior?
    Using `Space` button on any interactable HTML element (Textarea, Input,
    Select, Link, Button) register the event on the element and don't
    trigger expand/collapse on stack view block.
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    (cherry picked from commit 4c06b91)
    valentin-mladenov authored and github-actions[bot] committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    69a36e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    669b6ae View commit details
    Browse the repository at this point in the history