Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datagrid): expose top index change event for virtual scroller #1734

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Mar 7, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2597

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Mar 7, 2025

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

This PR introduces visual changes: 3ce4907
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout scrolling-based-on-top-visible-index
git fetch https://github.com/vmware-clarity/ng-clarity.git 3ce49077896ca6194d5c06533725f108de96f0e0
git cherry-pick 3ce49077896ca6194d5c06533725f108de96f0e0
git push

@valentin-mladenov valentin-mladenov marked this pull request as ready for review March 12, 2025 13:03
@valentin-mladenov valentin-mladenov self-assigned this Mar 12, 2025
@valentin-mladenov valentin-mladenov requested a review from a team March 12, 2025 13:03
@valentin-mladenov
Copy link
Contributor Author

related to #1719

@valentin-mladenov valentin-mladenov changed the title feat(datagrid): expose current top index event for virtual scroller feat(datagrid): expose top index change event for virtual scroller Mar 12, 2025
Copy link
Contributor

This PR introduces visual changes: b68045c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout scrolling-based-on-top-visible-index
git fetch https://github.com/vmware-clarity/ng-clarity.git b68045ccdb5e2e20565dbe77d8b460fa32e18c8c
git cherry-pick b68045ccdb5e2e20565dbe77d8b460fa32e18c8c
git push

@valentin-mladenov valentin-mladenov marked this pull request as draft March 12, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants