Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datagrid): interactive html element focus in datagrid cell #1739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(datagrid): interactive html element focus in datagrid cell #1739

wants to merge 1 commit into from

Conversation

spadidapelli
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2603

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

👋 @spadidapelli,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@spadidapelli spadidapelli self-assigned this Mar 12, 2025
valentin-mladenov
valentin-mladenov requested changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write a unit tests in key-navigation-grid.controller.spec.ts

projects/angular/src/data/datagrid/utils/key-navigation-grid.controller.ts
@@ -201,6 +201,7 @@ export class KeyNavigationGridController implements OnDestroy {
} else {
const tabbableElements = getTabbableItems(activeCell);
elementToFocus = tabbableElements.length ? tabbableElements[0] : activeCell;
elementToFocus.setAttribute('tabindex', '0');
Copy link
Contributor

@valentin-mladenov valentin-mladenov Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In prior section if the active cell have tabbable element in it. The tabbable element tab index should be removed tabbableElements[0].removeAttribute('tabindex');.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other more relaiable way is to skip setting tabindex to zero for the action cells.

@kevinbuhmann kevinbuhmann changed the title feat(datagrid): Intreractive html element focus in datagrid cell feat(datagrid): interactive html element focus in datagrid cell Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentin-mladenov valentin-mladenov valentin-mladenov requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@spadidapelli spadidapelli

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spadidapelli @valentin-mladenov @vmwclabot