feat(sidenav): remove deprecated sidenav in favor of vertical nav #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
kevinbuhmann
force-pushed
the
kevin/breaking/remove-sidenav
branch
from
618f862
to
bd611d0
Compare
The vertical nav styles shouldn't be used alone. The component should be used to ensure proper accessibility.
The sidenav is deprecated in favor of the vertical nav. I removed the responsive nav code snippets also because they demoed usage of the sidenav.
The sidenav is deprecated in favor of the vertical nav. I couldn't get the progress bar to work well in the vertical nav.
The sidenav is deprecated in favor of the vertical nav.
The sidenav is deprecated in favor of the vertical nav.
The "grid" layout makes doesn't wrap and makes it hard to add/remove things.
closes #316 BREAKING CHANGE: The deprecated sidenav is removed. Please migrate to the clr-verical-nav component.
kevinbuhmann
force-pushed
the
kevin/breaking/remove-sidenav
branch
from
bd611d0
to
7d8bc1d
Compare
Jinnie
approved these changes
Dec 16, 2022
|
🎉 This PR is included in version 15.0.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kevinbuhmann
changed the title
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
|
This PR removed from SCSS variables for the wizard sidenav. I will fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #316
replaces #334
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Feature
Breaking change
What is the current behavior?
The sidenav exists. It is fundamentally inaccessible and cannot be made accessible.
What is the new behavior?
The sidenav does not exist.
Does this PR introduce a breaking change?
Yes. Users should migrate to the vertical nav component.