Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wizard): remove deprecated, undocumented inline wizard mode #419

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

kevinbuhmann
Copy link
Member

PR Checklist

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Remove deprecated feature.

What is the current behavior?

Inline wizards are deprecated.

What is the new behavior?

Inline wizards are removed.

Does this PR introduce a breaking change?

Yes.

  • The inline wizard mode has been removed.
  • The clrModalOverrideScrollService modal input has been removed.

BREAKING CHANGE:
- The inline wizard mode has been removed.
- The `clrModalOverrideScrollService` modal input has been removed.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the website. There are some website demos that show the wizard inline.
AFAIK, this is the only reason for this code to exist.
I don't insist to have these unrealistic demos on the website, but before we remove this code, we'd better have the website updated and uploaded.

@kevinbuhmann
Copy link
Member Author

This will break the website. There are some website demos that show the wizard inline.
AFAIK, this is the only reason for this code to exist.
I don't insist to have these unrealistic demos on the website, but before we remove this code, we'd better have the website updated and uploaded.

I didn't see any, but I'll look again. I'll working on a v15 website that would include this change.

@kevinbuhmann
Copy link
Member Author

kevinbuhmann commented Dec 7, 2022

I didn't see any, but I'll look again. I'll working on a v15 website that would include this change.

I just looked again, and there are no inline wizards on the website. The wizard that appears inline on https://clarity.design/documentation/wizards is really a modal wizard. It's inside an .in-place-takeover element that makes it not render full screen. Note the animations when you close and reopen it.

Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it had only remained in the demo app then, and I see you removed it from there.
Thanks!

@kevinbuhmann kevinbuhmann marked this pull request as draft December 12, 2022 13:56
@kevinbuhmann kevinbuhmann marked this pull request as ready for review December 15, 2022 21:56
@kevinbuhmann kevinbuhmann merged commit 7470769 into beta Dec 19, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/breaking/remove-inline-wizard branch December 19, 2022 14:25
@github-actions
Copy link
Contributor

🎉 This PR is included in version 15.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants