-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): prevent flashing on option selected #679
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking this case and providing the fix.
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? The combobox popover is flashing on option selection due to opacity change of the popover content. Opacity was set to 0 when the "realign" is called which was not needed in this case. It is needed only on initial creation of the popover when the position of it is top: 0, left:0 and then when it's in the right position it would appear. Issue Number: CDE-11 ## What is the new behavior? No longer flashing. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? The combobox popover is flashing on option selection due to opacity change of the popover content. Opacity was set to 0 when the "realign" is called which was not needed in this case. It is needed only on initial creation of the popover when the position of it is top: 0, left:0 and then when it's in the right position it would appear. Issue Number: CDE-11 ## What is the new behavior? No longer flashing. ## Does this PR introduce a breaking change? - [ ] Yes - [X] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information
🎉 This PR is included in version 15.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The combobox popover is flashing on option selection due to opacity change of the popover content. Opacity was set to 0 when the "realign" is called which was not needed in this case. It is needed only on initial creation of the popover when the position of it is top: 0, left:0 and then when it's in the right position it would appear.
Issue Number: CDE-11
What is the new behavior?
No longer flashing.
Does this PR introduce a breaking change?
Other information