Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add button css docs #707

Merged
merged 2 commits into from
Jun 27, 2023
Merged

chore: add button css docs #707

merged 2 commits into from
Jun 27, 2023

Conversation

kevinbuhmann
Copy link
Member

CDE-256

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/button-css-docs branch 3 times, most recently from 20d6cd7 to 144a98d Compare May 24, 2023 17:05
projects/angular/src/button/API.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few wording details for consistency.
I'll post more info in the dev channel.


## CSS Variables

| CSS Variable Name | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls, rename to CSS Custom Properties


| CSS Variable Name | Description |
| ----------------------------------------------- | --------------------------------------------------------------------------------------- |
| --clr-btn-vertical-margin | Changes the button top and bottom margin. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove all the "Changes the..." and similar phrasing and leave the main data only.
Applies to all following items.


| Class name | Description |
| ------------------- | --------------------------------------------------------------------------- |
| btn | Styles a `button` element. All of the following require this class as well. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for "Styles a..."

@kevinbuhmann kevinbuhmann requested review from Jinnie and a team June 26, 2023 19:10
@kevinbuhmann kevinbuhmann merged commit cfa6b57 into main Jun 27, 2023
@kevinbuhmann kevinbuhmann deleted the kevin/button-css-docs branch June 27, 2023 13:58
@github-actions
Copy link
Contributor

🎉 This PR is included in version 15.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants