Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add tokens and update shim #860

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team August 7, 2023 13:06
@valentin-mladenov valentin-mladenov self-assigned this Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This PR introduces visual changes: 9942ed3
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout token-migration-tables_cde-783
git fetch https://github.com/vmware-clarity/ng-clarity.git 9942ed35fa2f18211afb769ae8bcf7b1d1a9b48f
git cherry-pick 9942ed35fa2f18211afb769ae8bcf7b1d1a9b48f
git push

Copy link
Contributor

@dtsanevmw dtsanevmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This PR introduces visual changes: 1ccaaa9
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout token-migration-tables_cde-783
git fetch https://github.com/vmware-clarity/ng-clarity.git 1ccaaa98d15ab1bb27687d2675920bf8a6c0f68f
git cherry-pick 1ccaaa98d15ab1bb27687d2675920bf8a6c0f68f
git push

@valentin-mladenov valentin-mladenov merged commit 2e080e5 into main Aug 8, 2023
@valentin-mladenov valentin-mladenov deleted the token-migration-tables_cde-783 branch August 8, 2023 08:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

🎉 This PR is included in version 15.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants