-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Rust py example #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @assambar! I haven't tested my own suggestions, but the idea is that crates can be referred to locally with path
, without the need to pull from GitHub -- what would enforce us to push, or use a cargo override. If we can refer to this dependency crates locally on the filesystem I think it would be great.
LGTM!
Co-authored-by: Rafael Fernández López <rfernandezl@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just added a few minor comments on the different crates. I love to see how easy is to embed now our Python + Wasm build 😄
wasi_py_rs["wasi-py-rs"] --> pyo3["pyo3"] | ||
pyo3 --> pyo3-ffi | ||
pyo3-ffi -..-> libpython3.11.a | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this!
81b295d
to
10baf1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @assambar! 👏
Add helper crates for usage of
libpython
in Rust.libpython
from Wasm Language Runtimes in wasm32-wasi modules built in RustImprove the example, which demonstrates how to embed
libpython
in Rust - `python/examples/embedding/wasm-py-rsHere is the readme - https://github.com/vmware-labs/webassembly-language-runtimes/tree/rust-py-example/python/examples/embedding/wasi-py-rs`