Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
shivaani0505 committed Jan 11, 2022
1 parent 9d8c18d commit 41afe58
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
#@data/values-schema
#@schema/desc "OpenAPIv3 Schema for kapp-controller"
---
#@schema/desc "The namespace value used by older templates, will overwrite with top level namespace of present, for backward compatibility"
#@schema/desc "The namespace in which to deploy kapp-controller"
namespace: kapp-controller
#@schema/desc "Configuration for kapp-controller"
kappController:
#@schema/desc "The namespace value used by older templates, will overwrite with top level namespace of present, for backward compatibility"
#@schema/desc "The namespace value used by older templates, will overwrite with top level namespace if present, for backward compatibility"
#@schema/nullable
namespace: kapp-controller
#@schema/desc "Whether to create namespace specified for kapp-controller"
Expand All @@ -18,10 +18,10 @@ kappController:
#@schema/desc "The coreDNSIP will be injected into /etc/resolv.conf of kapp-controller pod"
#@schema/nullable
coreDNSIP: ""
#@schema/desc "HostNetwork of kapp-controller deployment"
#@schema/desc "Host networking requested for kapp-controller pod. Use the host's network namespace. If this option is set, the ports that will be used must be specified"
#@schema/nullable
hostNetwork: ""
#@schema/desc "PriorityClassName of kapp-controller deployment"
#@schema/desc "The priority value that various system components use to find the priority of the kapp-controller pod"
#@schema/nullable
priorityClassName: ""
#@schema/desc "Concurrency of kapp-controller deployment"
Expand Down
10 changes: 5 additions & 5 deletions addons/packages/kapp-controller/0.30.0/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
spec:
fetch:
- imgpkgBundle:
image: projects.registry.vmware.com/tce/kapp-controller@sha256:001bb2cb7274d29b2146e9717c80c3672a99e40afdc2fbc442f4f77a32d6f90d
image: projects.registry.vmware.com/tce/kapp-controller@sha256:491a4a19fcb0bea4d99d7c087bb061cae88d569ca029b2d230b3814fde84692c
template:
- ytt:
paths:
Expand All @@ -32,7 +32,7 @@ spec:
namespace:
type: string
default: kapp-controller
description: The namespace value used by older templates, will overwrite with top level namespace of present, for backward compatibility
description: The namespace in which to deploy kapp-controller
kappController:
type: object
additionalProperties: false
Expand All @@ -42,7 +42,7 @@ spec:
type: string
default: null
nullable: true
description: The namespace value used by older templates, will overwrite with top level namespace of present, for backward compatibility
description: The namespace value used by older templates, will overwrite with top level namespace if present, for backward compatibility
createNamespace:
type: boolean
default: true
Expand All @@ -64,12 +64,12 @@ spec:
type: string
default: null
nullable: true
description: HostNetwork of kapp-controller deployment
description: Host networking requested for kapp-controller pod. Use the host's network namespace. If this option is set, the ports that will be used must be specified
priorityClassName:
type: string
default: null
nullable: true
description: PriorityClassName of kapp-controller deployment
description: The priority value that various system components use to find the priority of the kapp-controller pod
concurrency:
type: integer
default: 4
Expand Down
2 changes: 1 addition & 1 deletion hack/packages/verify-openapischema-for-package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ verify_openapischema_for_package() {
yq e '.components.schemas.dataValues' generated-openapi-schema.yaml > schema-contents.yaml
yq e '.spec.valuesSchema.openAPIv3' ../package.yaml > package-schema-contents.yaml
diffyaml schema-contents.yaml package-schema-contents.yaml
echo -e "${GREEN}===> OpenAPIv3 contents match successful for schema and package${NC}"
echo -e "${GREEN}===> OpenAPIv3 contents successfully matched for schema and package${NC}"
else
echo -e "${RED}===> ytt manifests could not be generated!!${NC}"
exit 1
Expand Down

0 comments on commit 41afe58

Please sign in to comment.