This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
enable opt-in K8s logging exclusion for fluent-bit #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think maybe this build failure is spurious, but please let me know if I'm wrong about that. |
akodali18
approved these changes
Jul 12, 2021
stmcginnis
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The fluent-bit Kubernetes filter provides an option for excluding pods from fluent-bit's log collection. This PR enables this option by default, allowing the fluent-bit pods themselves to be excluded from log collection.
https://docs.fluentbit.io/manual/pipeline/filters/kubernetes
This is important for the OOTB install experience for the fluent-bit package. By default, all logs are written to STDOUT on the
fluent-bitpod, unless the user customizes the fluent-bit install to point to another service, such as ElasticSearch, Loki, or Syslog. By excluding the logs from the fluent-bit pods themselves from log collection, we avoid an infinite logging loop where the fluent-bit pods would ingest their own log output and output it back again.The pods in the DaemonSet are already annotated appropriately for exclusion from log ingestion, but we missed the required
K8S-Logging.Excludeflag when we investigated this previously.