This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
add apiserver recording rules for prometheus #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
akodali18
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Thanks @LukeWinikates , lgtm, approving but lets merge once we update the description with the testing done details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This adds recording rules and a scrape configuration required for the 'Kubernetes / API Server' grafana dashboard
Describe testing done for PR
Updated the Prometheus package and deployed to a standalone cluster on Docker, along with the Grafana package. Confirmed that the graphs in the 'Kubernetes / API Server' dashboard are now populated.