-
Notifications
You must be signed in to change notification settings - Fork 307
Conversation
I'm guessing all these header rules, mixed content, etc don't handle windows comments or etc?? 🤷♂️ |
and does https://github.com/vmware-tanzu/tce/pull/1095/files#diff-8b45cb85c7b0c8e9578446dcaddac99891c87ad917aed2e368edd6bb32ce5637R120 this need to be in the looks like there is a PR already for this maybe? |
cb764f9
to
94e5769
Compare
fix where we save the kind cluster objects to match new core config location update standalone with new config/metadata dir windows support fix packaging script add in windows script update to install script fix sa plugin fix windows folders update packaging script fix copy and permissions add correct package fix config directory
94e5769
to
5668d1a
Compare
confirmed with @jpmcb that we need these changes along with the one on the merged PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install worked for me!! Got to the same point you did with the existing errors we're seeing in tanzu-framework.
One snag I hit was that was:
Get "https://projects-stg.registry.vmware.com/v2/": x509: certificate signed by unknown authority
which I'm guess was since I was off the VPN when I started
Yup, that won't resolve/connect unless you are on VPN. Unless there are any objections, I'm going to merge this tomorrow morning. This will be followed by updates to the signing process for windows which do not affect Linux and MacOS packages/builds. |
Sounds great!! 🚀 |
What this PR does / why we need it
This PR builds and packages a windows tarball complete with an install.bat file similar to the one that exists for linux/mac. The install script will land the binaries in the appropriate locations.
NOTE: Install docker desktop on windows before starting this process!
I have only tested this on Windows 10 with all the updates installed. In order to correctly run the install.bat, extract the tarball then:
command
run as administrator
install.bat
Which issue(s) this PR fixes
Addresses TCE use on Windows
Describe testing done for PR
I tried to deploy natively on Windows but are still hitting issues in Tanzu Framework that are affecting Mac and Linux
Special notes for your reviewer
The UI will run, but the deploy will fail
Does this PR introduce a user-facing change?
Yes! We need windows docs, etc