Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Bump Contour to 1.17.1 #1160

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Bump Contour to 1.17.1 #1160

merged 4 commits into from
Jul 26, 2021

Conversation

sunjayBhatia
Copy link
Contributor

What this PR does / why we need it

Bumps Contour to 1.17.1 for GHSA-5ph6-qq5x-7jwc

Which issue(s) this PR fixes

N/A

Describe testing done for PR

TBD

Special notes for your reviewer

N/A

Does this PR introduce a user-facing change?

Kubernetes Services of type ExternalName will now not be processed by Contour.

Also see Contour release note: https://github.com/projectcontour/contour/releases/tag/v1.17.1

@sunjayBhatia
Bump Contour to 1.17.1
07fed0d 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner July 23, 2021 15:10
@github-actions github-actions bot added owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer labels Jul 23, 2021
skriss
skriss suggested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add the new version to https://github.com/vmware-tanzu/tce/blob/main/addons/repos/main.yaml#L7-L9

addons/packages/contour/1.17.1/README.md
Comment on lines +1 to +3
# THIS CONTENT HAS MOVED TO THE DOCS BRANCH: PLEASE MAKE ANY FURTHER UPDATES THERE

File is available here on docs branch: ``docs\site\content\docs\latest\contour-config``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to make of this, the file referenced here in the docs branch does not include any of the configuration reference. So yeah probably makes sense to continue to add this README.md for each new version.

@sunjayBhatia
Missing 1.17 references
24b8a77 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia
Update releasedAt
54c571e 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia
Copy link
Contributor Author

thanks for the checks @skriss missed those version numbers!

@sunjayBhatia sunjayBhatia requested a review from skriss July 23, 2021 15:50
skriss
skriss reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, just have the one question on the Package bundle SHA which we need some input from TCE maintainers on.

@seemiller
Copy link
Contributor

I've given the Contour team permission to push packages to the OCI registry

@sunjayBhatia
update imgpkg bundle
6431140 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
skriss approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunjayBhatia
Copy link
Contributor Author

cc @vmware-tanzu/tce-owners

@sunjayBhatia
Copy link
Contributor Author

ok not sure if that is a real team ^ but the merge is blocked on it, can't find it in the github UI or to request a review from

seemiller
seemiller approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@seemiller seemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemiller seemiller merged commit 6fc2bdb into vmware-tanzu:main Jul 26, 2021
@seemiller seemiller deleted the bump-contour-1.17.1 branch July 26, 2021 20:02
@sunjayBhatia
Copy link
Contributor Author

@seemiller is it possible the tce-owners team is not set to visible in the team settings? would be useful to make it visible if it isn't since that team is mentioned in the CODEOWNERS file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seemiller seemiller seemiller approved these changes

@skriss skriss skriss approved these changes

Assignees
No one assigned
Labels
owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunjayBhatia @seemiller @skriss