This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Contour fix job #1184
Merged
Contour fix job #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
skriss
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Contour runs a Job that has a ttl set to 0, so that it gets immediately removed and kapp-controllers fails to validate existence of the job.
This PR removes the ttl and add a kapp annotation so that Job is recreated every time as instructed by @cppforlife
Which issue(s) this PR fixes
No issue is opened for this.
Describe testing done for PR
Tested with
ytt -f configin the bundle dir andytt -f config -v certificates.useCertManager=trueto test both cases defined in the modified overlay file. Tested both versions of the package.