This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Revert using a PR to bump release version #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidvonthenen
changed the title
davidvonthenen
requested review from
joshrosso,
jpmcb,
seemiller and
stmcginnis
|
going to merge since approvals this week are going to be slow. if anyone objects to this, I can follow up with a PR to address those objections. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
With a the branch rule changes after upgrading to enterprise, we need to revert back to the older mechanism for the timing being. Instead of using a PR to bump the dev version, we need to roll back to the old method.
The branch rules and
ghCLI options don't allow to approve my own PR even though the GH UI does have an "I'm an administrator and it's ok to merge". This feature is currently being worked on:cli/cli#1198