Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Add a schema to gatekeeper package #1959

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Add a schema to gatekeeper package #1959

merged 1 commit into from
Sep 29, 2021

Conversation

joshrosso
Copy link
Contributor

@joshrosso joshrosso commented Sep 24, 2021

What this PR does / why we need it

This adds a schema defintion to the gatekeeper package, which enables
the tanzu CLI to provide a list of configurable values.

Details for the Release Notes (PLEASE PROVIDE)

Schema added to the gatekeeper package. This is now exposed via `tanzu package
available get gatekeeper.community.tanzu.vmware.com/1.0.0 --values-schema`.

Which issue(s) this PR fixes

Describe testing done for PR

  1. Bootstrap a cluster.

    tanzu standalone-cluster create -i docker test
  2. Apply the package.

    kubectl apply -f addons/packages/gatekeeper/metadata.yaml
    kubectl apply -f addons/packages/gatekeeper/3.2.3/package.yaml
  3. Verify values are now exposed.

    tanzu package available get gatekeeper.community.tanzu.vmware.com/1.0.0 --values-schema
    
    | Retrieving package details for gatekeeper.community.tanzu.vmware.com/1.0.0...
      KEY        DEFAULT            TYPE    DESCRIPTION
      namespace  gatekeeper-system  string  The namespace in which to deploy gatekeeper.
  4. Verify the package installs

    tanzu package install gk --package-name gatekeeper.community.tanzu.vmware.com --version 1.0.0
    $ kubectl get po -A
    NAMESPACE           NAME                                                     READY   STATUS    RESTARTS   AGE
    gatekeeper-system   gatekeeper-audit-7fdbcfdb8-jl8ft                         1/1     Running   0          38s
    gatekeeper-system   gatekeeper-controller-manager-f8887b97d-hjxnj            1/1     Running   0          38s
    kube-system         antrea-agent-fq7gs                                       2/2     Running   0          11m
    kube-system         antrea-agent-xftl2                                       2/2     Running   0          11m
    kube-system         antrea-controller-86f8988c5f-tbbqk                       1/1     Running   0          11m
    kube-system         coredns-8dcb5c56b-482kd                                  1/1     Running   0          11m
    kube-system         coredns-8dcb5c56b-zmfm6                                  1/1     Running   0          11m
    kube-system         etcd-henro-control-plane-qq6cn                           1/1     Running   0          11m
    kube-system         kube-apiserver-henro-control-plane-qq6cn                 1/1     Running   0          11m
    kube-system         kube-controller-manager-henro-control-plane-qq6cn        1/1     Running   0          11m
    kube-system         kube-proxy-2lhmf                                         1/1     Running   0          11m
    kube-system         kube-proxy-qvzv7                                         1/1     Running   0          11m
    kube-system         kube-scheduler-henro-control-plane-qq6cn                 1/1     Running   0          11m
    tkg-system          kapp-controller-6499b8866-fhlmv                          1/1     Running   0          11m
    tkg-system          tanzu-capabilities-controller-manager-6ff97656b8-z7dcb   1/1     Running   0          11m
    tkr-system          tkr-controller-manager-6bc455b5d4-w8thd                  1/1     Running   0          11m

Special notes for your reviewer

Alone with reviewing the diff, please validate the testing described above.

This adds a schema defintion to the gatekeeper package, which enables
the tanzu CLI to provide a list of configurable values.

Signed-off-by: joshrosso <rossoj@vmware.com>
@joshrosso joshrosso requested a review from seemiller September 24, 2021 18:02
@joshrosso joshrosso requested a review from a team as a code owner September 24, 2021 18:02
@github-actions github-actions bot added the owner/packages Work executed by a package's maintainer label Sep 24, 2021
@joshrosso joshrosso requested review from jpmcb and removed request for seemiller September 29, 2021 03:57
@joshrosso
Copy link
Contributor Author

@jpmcb if you've got time to today to look at that i'd greatly appreciate it!

Copy link
Contributor

@seemiller seemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemiller seemiller merged commit 43391aa into vmware-tanzu:main Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/packages Work executed by a package's maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema/properties to gatekeeper package
3 participants